Skip to content

[Zellic] 1 missing input validation on user inputs #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
manishbista28 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Zellic] 1 missing input validation on user inputs #42

manishbista28 wants to merge 8 commits into from

Conversation

@manishbista28
Copy link
Contributor

@manishbista28 manishbista28 commented Dec 17, 2025 •
edited
Loading

Fixes
#50

Includes

  • field bound check
  • on-curve check
  • on-subgroup check

For

  • groth16_verify
  • groth16_verify_compressed

@manishbista28 manishbista28 self-assigned this Dec 17, 2025
@manishbista28
Copy link
Contributor Author

manishbista28 commented Dec 17, 2025

Commit Details:

3bb848b for subgroup check
9205ecf for field bounds check
d341c7c to 36f33d7 for on-curve check on compressed serialized input
6e4bb3c for on-curve check on uncompressed deserialized input
aae3e77 to merge all of these types of validation checks

@manishbista28 manishbista28 changed the title Zelic/1 missing input validation on user inputs Zellic/1 missing input validation on user inputs Dec 17, 2025
@manishbista28
Copy link
Contributor Author

manishbista28 commented Dec 17, 2025

The same changes have also been done through
PR #34 , #35 and #38
Will close them if it's easier to review directly through this PR. @AaronFeickert

@manishbista28 manishbista28 changed the title Zellic/1 missing input validation on user inputs [Zellic] 1 missing input validation on user inputs Dec 17, 2025
@manishbista28 manishbista28 marked this pull request as ready for review December 17, 2025 07:27
This was linked to issues Dec 19, 2025
audit: deserialize proof with validation checks #4
Open
audit: add G2 subgroup check #5
Open
audit: bounds check on field elements of input proof #10
Open
@manishbista28 manishbista28 linked an issue Dec 22, 2025 that may be closed by this pull request
[Zellic] 1 missing input validation on user inputs #50
Open
This was unlinked from issues Dec 22, 2025
audit: deserialize proof with validation checks #4
Open
audit: add G2 subgroup check #5
Open
audit: bounds check on field elements of input proof #10
Open
@manishbista28 manishbista28 mentioned this pull request Dec 22, 2025
Open
@manishbista28 manishbista28 mentioned this pull request Jan 5, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@manishbista28 manishbista28

Labels

audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Zellic] 1 missing input validation on user inputs

2 participants

@manishbista28